Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: circuit breaker로 날씨 API 이중화 #213

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Feat: circuit breaker로 날씨 API 이중화 #213

merged 5 commits into from
Sep 19, 2024

Conversation

Jaewon-pro
Copy link
Member

@Jaewon-pro Jaewon-pro commented Sep 19, 2024 •
edited
Loading

🔗 이슈 연결

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • resilience4j 의존성을 추가합니다.
  • openweathermap api를 메인으로 사용하고, 해당 API를 사용할 수 없는 경우 weatherApiCom api를 사용합니다.
  • resilience4j의 circuit breaker 상태 정보를 actuator에서 확인할 수 있도록 application.yml에 설정합니다.
  • 위에서 언급한 날씨 api 2개 모두 timeout 시간을 변경합니다.
    • read timeout: 5초 -> 1초
    • connection timeout: 10초 -> 3초
  • main, fallback api 모두 실패한 경우, 에러 로그를 남기고 빈 날씨 응답값을 반환하도록 합니다.

🔍 리뷰 요청/참고 사항

@Jaewon-pro Jaewon-pro self-assigned this Sep 19, 2024
hee9841
hee9841 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@Jaewon-pro Jaewon-pro merged commit 08c1576 into main Sep 19, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the feature/#212/weather-duplexing branch September 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hee9841 hee9841 hee9841 approved these changes

Assignees

@Jaewon-pro Jaewon-pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

날씨 API 이중화
2 participants
@Jaewon-pro @hee9841