Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: DeviceType, Version, ServerVersionService 클래스 추가 #220

Merged
merged 4 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/com/dnd/runus/application/server/DeviceType.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.dnd.runus.application.server;

import lombok.Getter;

@Getter
public enum DeviceType {
IOS(new Version(1, 0, 0)),
;
private final Version minSupportedVersion;

DeviceType(Version version) {
this.minSupportedVersion = version;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.dnd.runus.application.server;

import org.springframework.stereotype.Service;

@Service
public class ServerVersionService {
public boolean isUpdateRequired(Version version, DeviceType client) {
return version.isOlderThan(client.getMinSupportedVersion());
}
}
27 changes: 27 additions & 0 deletions src/main/java/com/dnd/runus/application/server/Version.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package com.dnd.runus.application.server;

public record Version(int major, int minor, int patch) implements Comparable<Version> {
public static Version parse(String version) {
String[] split = version.split("\\.");
if (split.length < 2 || split.length > 3) {
throw new IllegalArgumentException("Invalid version format [" + version + "]");
}
int patch = split.length > 2 ? Integer.parseInt(split[2]) : 0;
return new Version(Integer.parseInt(split[0]), Integer.parseInt(split[1]), patch);
}

@Override
public int compareTo(Version o) {
if (major != o.major) {
return major - o.major;
}
if (minor != o.minor) {
return minor - o.minor;
}
return patch - o.patch;
}

public boolean isOlderThan(Version version) {
return compareTo(version) < 0;
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package com.dnd.runus.presentation.v1.server;

import com.dnd.runus.application.server.DeviceType;
import com.dnd.runus.application.server.ServerVersionService;
import com.dnd.runus.application.server.Version;
import com.dnd.runus.presentation.v1.server.dto.response.VersionStatusResponse;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
import lombok.RequiredArgsConstructor;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -15,10 +19,13 @@
@RequestMapping("api/v1/servers")
public class ServerController {

private final ServerVersionService serverVersionService;

@GetMapping("versions")
@Operation(summary = "앱의 버전을 확인합니다.")
@Operation(summary = "앱 버전 지원 여부 확인", description = "기기의 앱 버전을 확인하고 앱 업데이트가 필요한지 여부를 반환합니다.")
@Parameter(name = "version", description = "앱 버전", required = true, example = "1.0.0")
public VersionStatusResponse checkVersion(@RequestParam String version) {
// FIXME: 버전 체크 로직 구현 필요
return new VersionStatusResponse(false);
boolean updateRequired = serverVersionService.isUpdateRequired(Version.parse(version), DeviceType.IOS);
return new VersionStatusResponse(updateRequired);
}
}
58 changes: 58 additions & 0 deletions src/test/java/com/dnd/runus/application/server/VersionTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
package com.dnd.runus.application.server;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

import static org.junit.jupiter.api.Assertions.*;

class VersionTest {

@Test
void parse() {
Version version = Version.parse("1.2.3");
assertEquals(1, version.major());
assertEquals(2, version.minor());
assertEquals(3, version.patch());
}

@Test
void parseWithoutPatch() {
Version version = Version.parse("1.2");
assertEquals(1, version.major());
assertEquals(2, version.minor());
assertEquals(0, version.patch());
}

@ParameterizedTest
@MethodSource("compareToProvider")
void compareTo(Version version1, Version version2, int expected) {
assertEquals(expected, version1.compareTo(version2));
}

@Test
void isOlderThan() {
Version version = new Version(1, 2, 3);

assertTrue(version.isOlderThan(new Version(1, 2, 4)));
assertTrue(version.isOlderThan(new Version(1, 3, 0)));
assertTrue(version.isOlderThan(new Version(2, 0, 0)));

assertFalse(version.isOlderThan(new Version(1, 2, 3)));
assertFalse(version.isOlderThan(new Version(1, 2, 2)));
assertFalse(version.isOlderThan(new Version(1, 1, 0)));
assertFalse(version.isOlderThan(new Version(0, 0, 0)));
}

private static Object[] compareToProvider() {
return new Object[] {
new Object[] {new Version(1, 2, 3), new Version(1, 2, 3), 0},
new Object[] {new Version(1, 2, 3), new Version(1, 2, 4), -1},
new Object[] {new Version(1, 2, 3), new Version(1, 3, 0), -1},
new Object[] {new Version(1, 2, 3), new Version(2, 0, 0), -1},
new Object[] {new Version(1, 2, 3), new Version(1, 2, 2), 1},
new Object[] {new Version(1, 2, 3), new Version(1, 1, 0), 1},
new Object[] {new Version(1, 2, 3), new Version(0, 0, 0), 1},
};
}
}