Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pace getJsonValue 메서드에서 초를 두 자리로 표현 #221

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Jaewon-pro
Copy link
Member

🔗 이슈 연결

  • x

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • Pace. getPace 메서드에서 기존에는 초 단위가 10 미만이면 한 자리로 표현합니다. (5’5”)
    • 초 단위가 10 미만이더라도 두 자리로 표현하도록 수정합니다. (5’05”)
    • 검증하는 테스트를 추가합니다.
  • 분 또는 초는 0 이상 60 미만의 값이 아닌 경우에 생성자에서 IllegalArgumentException 예외를 던지도록 추가합니다.

🔍 리뷰 요청/참고 사항

@Jaewon-pro Jaewon-pro self-assigned this Sep 23, 2024
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@Jaewon-pro Jaewon-pro merged commit 1a6775d into main Sep 23, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the feature/pace-seconds branch September 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants