Fix: 뱃지 리스트 조회 API 응답형식 변경 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BadgeWithAchievedStatus에 LocalDateTime achievedAt 값 추가 - BadgeWithAchieveStatusAndAchievedAt의 achievedAt 타입 OffsetDateTime에서 LocalDateTime으로 변경 - BadgeWithAchieveStatusAndAchievedAt의 achievedAt 타입변경으로 서비스 단 isRecent함수 criterionDate 인자타입 LocalDateTime으로 변경
Jaewon-pro
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
💡 반영할 내용 및 변경 사항 요약
🔍 리뷰 요청/참고 사항
BadgeWithAchievedStatus하고BadgeWithAchieveStatusAndAchievedAt부분을 합칠 수 있을 것 같은데 해당 부분은 시간되면 추후 리팩터링 하겠습니다.