Refactor getenv access using constructor #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcremer
changed the title
| public function __construct(array $env = []) | ||
| { | ||
| foreach (self::$envKeys as $key) { | ||
| $this->env[$key] = array_key_exists($key, $env) ? $env[$key] : getenv($key); |
There was a problem hiding this comment.
Possibly add an explicit string cast to $env[$key] to mirror the values we'll be getting back from getenv?
There was a problem hiding this comment.
$this->env is never declared, so it's a public property.
|
👍 (of course, I'm probably biased) |
bcremer
force-pushed
the
refactor-environment-access-alternative
branch
from
2fdc5f5 to
84deaaf
Compare
|
Included CR feedback from @bobthecow |
|
Any news on this @dnoegel, @bobthecow, @bcremer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another alternative to PR #6 and #7 including the idea of @bobthecow.