Added closing support for FrameStreamSockInput #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
FrameStreamSockInputdoes not support being closed. Depending on the use case, this may be undesirable since it may leak go-routines. Further, a broken listener (for whatever reason) lead to a busy loop whereReadIntowould spam "accept failed".This PR changes the following:
ReadIntonow keeps track of active connectionsReadIntoreturningReadIntowill close all accepted connectionsReadIntowill close thewaitchannelClosemethod, which closes the listenerWaitmethod now waits forwaitto be closedI'd be happy about feedback on the code or suggestions for further improvements.