-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor 5.x installation to allow for building where necessary #308
Conversation
Checked this the other day on a M1 (arm64) macbook, builds and runs great. Currently building on a armv7 Raspi, also seems to be building fine. |
Thanks for testing! I guess we'll merge for now and @acburdine can come back with more improvements/adjustments later (if desired!) ❤️ |
Changes: - docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
Sure! One thing I realized later: the v5 Alpine version doesn't build on armv7(I only tested the Debian builds) :( It's related to not building Sharp as mentioned in #293. The relevant lines from
|
Doh, great catch! Will update shortly. |
Changes: - docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0 - docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
Changes: - docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual - docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0 - docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp" - docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
Changes: - docker-library/ghost@819c182: Update to 5.2.1, ghost-cli 1.21.0 - docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual - docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0 - docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp" - docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
Changes: - docker-library/ghost@819c182: Update to 5.2.1, ghost-cli 1.21.0 - docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual - docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0 - docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp" - docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
@tianon Hey any update on v7 ? I don't get sharp installed on my end when attempting this. |
To fix this, use your own multi stage build. Install sharp normally (debian per example) than copy in within your image v7. |
@pascalandy Respectfully, that's not a fix. It's a workaround. |
It looks like When we move to Debian Bookworm, it will also have new enough "libvips": https://packages.debian.org/bookworm/libvips-dev. |
Closes #307
I don't love how complex this has become, but I do like that it's a lot more resilient? 😬 🙈
I've tested this successfully on at least
arm64v8
,s390x
, andppc64le
(the latter of which don't getsharp
successfully because they don't have pre-built or new enoughlibvips
😞).