Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 5.x installation to allow for building where necessary #308

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented May 24, 2022

Closes #307

I don't love how complex this has become, but I do like that it's a lot more resilient? 😬 🙈

I've tested this successfully on at least arm64v8, s390x, and ppc64le (the latter of which don't get sharp successfully because they don't have pre-built or new enough libvips 😞).

@tianon tianon requested review from acburdine and yosifkit May 24, 2022 21:34
@unverbraucht
Copy link

Checked this the other day on a M1 (arm64) macbook, builds and runs great. Currently building on a armv7 Raspi, also seems to be building fine.

@tianon
Copy link
Member Author

tianon commented Jun 1, 2022

Thanks for testing! I guess we'll merge for now and @acburdine can come back with more improvements/adjustments later (if desired!) ❤️

@tianon tianon merged commit c91b1df into docker-library:master Jun 1, 2022
@tianon tianon deleted the arm64+ branch June 1, 2022 15:23
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 1, 2022
Changes:

- docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
@unverbraucht
Copy link

Sure! One thing I realized later: the v5 Alpine version doesn't build on armv7(I only tested the Debian builds) :( It's related to not building Sharp as mentioned in #293. The relevant lines from docker build are:

+ '[' -n ' .build-deps-ghost .build-deps-sharp' ]
+ apk del --no-network .build-deps-ghost .build-deps-sharp
WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.15/main: No such file or directory
WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.15/community: No such file or directory
ERROR: No such package: .build-deps-sharp

@tianon
Copy link
Member Author

tianon commented Jun 1, 2022

Doh, great catch! Will update shortly.

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 1, 2022
Changes:

- docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0
- docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 1, 2022
Changes:

- docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual
- docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0
- docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp"
- docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 2, 2022
Changes:

- docker-library/ghost@819c182: Update to 5.2.1, ghost-cli 1.21.0
- docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual
- docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0
- docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp"
- docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
BaurzhanSakhariev pushed a commit to crate/official-images that referenced this pull request Jul 18, 2022
Changes:

- docker-library/ghost@819c182: Update to 5.2.1, ghost-cli 1.21.0
- docker-library/ghost@67269d3: Merge pull request docker-library/ghost#312 from infosiftr/virtual
- docker-library/ghost@d934156: Update to 5.2.0, ghost-cli 1.21.0
- docker-library/ghost@ae52dd8: Golf down the virtual declaration to avoid "ERROR: No such package: .build-deps-sharp"
- docker-library/ghost@c91b1df: Merge pull request docker-library/ghost#308 from infosiftr/arm64+
@XChikuX
Copy link

XChikuX commented Sep 1, 2023

@tianon Hey any update on v7 ?

I don't get sharp installed on my end when attempting this.

@pascalandy
Copy link
Contributor

pascalandy commented Sep 1, 2023

To fix this, use your own multi stage build. Install sharp normally (debian per example) than copy in within your image v7.

@XChikuX
Copy link

XChikuX commented Sep 1, 2023

@pascalandy Respectfully, that's not a fix. It's a workaround.

@yosifkit
Copy link
Member

yosifkit commented Sep 1, 2023

It looks like vips-dev on Alpine 3.17 (current base) is new enough for sharp now: https://pkgs.alpinelinux.org/packages?name=vips-dev&branch=v3.17&repo=&arch=&maintainer= (I'll make a PR).

When we move to Debian Bookworm, it will also have new enough "libvips": https://packages.debian.org/bookworm/libvips-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghost 5 alpine image won’t build
5 participants