Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharp module building #394

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yosifkit
Copy link
Member

Alpine 3.17 lib-vips is new enough for sharp

https://github.com/TryGhost/Ghost/blob/v5.65.1/yarn.lock#L28340-L28341
https://github.com/lovell/sharp/blob/v0.30.7/package.json#L157
https://pkgs.alpinelinux.org/packages?name=vips-dev&branch=v3.17

⬆️ this is a lot of manual checking to see which version of sharp that Ghost requires, and then which version of libvips that sharp requires, and then checking if that is available in the Alpine release we are on. I'd rather have some automation (in the Dockerfile?) to check these assumptions before just adding sharp back to the build-from-source deps.

Closes #293

@tianon
Copy link
Member

tianon commented Dec 8, 2023

Agreed, without something automated checking/verifying that whole chain of deps, this is not ideal. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants