-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: fix: Version 20.18 and drop ppc64le and x390x from Bullseye #17676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
requested review from
LaurentGoderre and
a team
as code owners
October 4, 2024 17:00
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
changed the title
Node: feat: Node.js 20.18.0
Node: ci: Add PR Write permission for official PR
Oct 4, 2024
LaurentGoderre
changed the title
Node: ci: Add PR Write permission for official PR
Node: Update to Node 20.18
Oct 4, 2024
Opened nodejs/docker-node#2146 to address the architecture failure in the Naughty job |
nodejs-github-bot
changed the title
Node: Update to Node 20.18
Node: fix: Drop ppc64le and x390x from Bullseye
Oct 4, 2024
nodejs-github-bot
force-pushed
the
node
branch
from
October 4, 2024 17:21
bbc3e12
to
4597ed0
Compare
Diff for 4597ed0:diff --git a/_bashbrew-cat b/_bashbrew-cat
index a75d96f..edefbe3 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -23,43 +23,43 @@ GitCommit: 619b871fb3d89dc6d6333914b46bf526e781eec5
Directory: 18/bookworm-slim
Tags: 18-bullseye, 18.20-bullseye, 18.20.4-bullseye, hydrogen-bullseye
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+Architectures: amd64, arm32v7, arm64v8
GitCommit: 619b871fb3d89dc6d6333914b46bf526e781eec5
Directory: 18/bullseye
Tags: 18-bullseye-slim, 18.20-bullseye-slim, 18.20.4-bullseye-slim, hydrogen-bullseye-slim
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+Architectures: amd64, arm32v7, arm64v8
GitCommit: 619b871fb3d89dc6d6333914b46bf526e781eec5
Directory: 18/bullseye-slim
-Tags: 20, 20-bookworm, 20.17, 20.17-bookworm, 20.17.0, 20.17.0-bookworm, iron, iron-bookworm, lts, lts-bookworm, lts-iron
+Tags: 20, 20-bookworm, 20.18, 20.18-bookworm, 20.18.0, 20.18.0-bookworm, iron, iron-bookworm, lts, lts-bookworm, lts-iron
Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/bookworm
-Tags: 20-alpine, 20-alpine3.20, 20.17-alpine, 20.17-alpine3.20, 20.17.0-alpine, 20.17.0-alpine3.20, iron-alpine, iron-alpine3.20, lts-alpine, lts-alpine3.20
+Tags: 20-alpine, 20-alpine3.20, 20.18-alpine, 20.18-alpine3.20, 20.18.0-alpine, 20.18.0-alpine3.20, iron-alpine, iron-alpine3.20, lts-alpine, lts-alpine3.20
Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/alpine3.20
-Tags: 20-alpine3.19, 20.17-alpine3.19, 20.17.0-alpine3.19, iron-alpine3.19, lts-alpine3.19
+Tags: 20-alpine3.19, 20.18-alpine3.19, 20.18.0-alpine3.19, iron-alpine3.19, lts-alpine3.19
Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/alpine3.19
-Tags: 20-bookworm-slim, 20-slim, 20.17-bookworm-slim, 20.17-slim, 20.17.0-bookworm-slim, 20.17.0-slim, iron-bookworm-slim, iron-slim, lts-bookworm-slim, lts-slim
+Tags: 20-bookworm-slim, 20-slim, 20.18-bookworm-slim, 20.18-slim, 20.18.0-bookworm-slim, 20.18.0-slim, iron-bookworm-slim, iron-slim, lts-bookworm-slim, lts-slim
Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/bookworm-slim
-Tags: 20-bullseye, 20.17-bullseye, 20.17.0-bullseye, iron-bullseye, lts-bullseye
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+Tags: 20-bullseye, 20.18-bullseye, 20.18.0-bullseye, iron-bullseye, lts-bullseye
+Architectures: amd64, arm32v7, arm64v8
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/bullseye
-Tags: 20-bullseye-slim, 20.17-bullseye-slim, 20.17.0-bullseye-slim, iron-bullseye-slim, lts-bullseye-slim
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: 410410f6955bf8d052ef3ec7988cd41a54eab879
+Tags: 20-bullseye-slim, 20.18-bullseye-slim, 20.18.0-bullseye-slim, iron-bullseye-slim, lts-bullseye-slim
+Architectures: amd64, arm32v7, arm64v8
+GitCommit: 8483b3edd9cc2a38360d88d360e3093d657ac3fe
Directory: 20/bullseye-slim
Tags: 22, 22-bookworm, 22.9, 22.9-bookworm, 22.9.0, 22.9.0-bookworm, bookworm, current, current-bookworm, latest
@@ -83,11 +83,11 @@ GitCommit: 58c3b39e5948f82c594395857193cd97d01c690e
Directory: 22/bookworm-slim
Tags: 22-bullseye, 22.9-bullseye, 22.9.0-bullseye, bullseye, current-bullseye
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+Architectures: amd64, arm32v7, arm64v8
GitCommit: 58c3b39e5948f82c594395857193cd97d01c690e
Directory: 22/bullseye
Tags: 22-bullseye-slim, 22.9-bullseye-slim, 22.9.0-bullseye-slim, bullseye-slim, current-bullseye-slim
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+Architectures: amd64, arm32v7, arm64v8
GitCommit: 58c3b39e5948f82c594395857193cd97d01c690e
Directory: 22/bullseye-slim
diff --git a/_bashbrew-list b/_bashbrew-list
index 3f3c0b0..0406c21 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -34,24 +34,24 @@ node:20-bookworm-slim
node:20-bullseye
node:20-bullseye-slim
node:20-slim
-node:20.17
-node:20.17-alpine
-node:20.17-alpine3.19
-node:20.17-alpine3.20
-node:20.17-bookworm
-node:20.17-bookworm-slim
-node:20.17-bullseye
-node:20.17-bullseye-slim
-node:20.17-slim
-node:20.17.0
-node:20.17.0-alpine
-node:20.17.0-alpine3.19
-node:20.17.0-alpine3.20
-node:20.17.0-bookworm
-node:20.17.0-bookworm-slim
-node:20.17.0-bullseye
-node:20.17.0-bullseye-slim
-node:20.17.0-slim
+node:20.18
+node:20.18-alpine
+node:20.18-alpine3.19
+node:20.18-alpine3.20
+node:20.18-bookworm
+node:20.18-bookworm-slim
+node:20.18-bullseye
+node:20.18-bullseye-slim
+node:20.18-slim
+node:20.18.0
+node:20.18.0-alpine
+node:20.18.0-alpine3.19
+node:20.18.0-alpine3.20
+node:20.18.0-bookworm
+node:20.18.0-bookworm-slim
+node:20.18.0-bullseye
+node:20.18.0-bullseye-slim
+node:20.18.0-slim
node:22
node:22-alpine
node:22-alpine3.19
diff --git a/node_lts-alpine3.19/Dockerfile b/node_lts-alpine3.19/Dockerfile
index a1d74a1..fe29479 100644
--- a/node_lts-alpine3.19/Dockerfile
+++ b/node_lts-alpine3.19/Dockerfile
@@ -1,6 +1,6 @@
FROM alpine:3.19
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN addgroup -g 1000 node \
&& adduser -u 1000 -G node -s /bin/sh -D node \
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
curl \
&& ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
&& case "${alpineArch##*-}" in \
- x86_64) ARCH='x64' CHECKSUM="913547514c21152f09d46b8b140d30dd5ea40d2e3ac4ddc6ff3e12a666bec482" OPENSSL_ARCH=linux-x86_64;; \
+ x86_64) ARCH='x64' CHECKSUM="757bba0adff8eaadfa7f9be2c87a35d5010ac3f71b5527e57385218c806a4fa4" OPENSSL_ARCH=linux-x86_64;; \
x86) OPENSSL_ARCH=linux-elf;; \
aarch64) OPENSSL_ARCH=linux-aarch64;; \
arm*) OPENSSL_ARCH=linux-armv4;; \
@@ -45,14 +45,12 @@ RUN addgroup -g 1000 node \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \
diff --git a/node_lts-alpine3.20/Dockerfile b/node_lts-alpine3.20/Dockerfile
index bce7e7c..47aea13 100644
--- a/node_lts-alpine3.20/Dockerfile
+++ b/node_lts-alpine3.20/Dockerfile
@@ -1,6 +1,6 @@
FROM alpine:3.20
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN addgroup -g 1000 node \
&& adduser -u 1000 -G node -s /bin/sh -D node \
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
curl \
&& ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
&& case "${alpineArch##*-}" in \
- x86_64) ARCH='x64' CHECKSUM="913547514c21152f09d46b8b140d30dd5ea40d2e3ac4ddc6ff3e12a666bec482" OPENSSL_ARCH=linux-x86_64;; \
+ x86_64) ARCH='x64' CHECKSUM="757bba0adff8eaadfa7f9be2c87a35d5010ac3f71b5527e57385218c806a4fa4" OPENSSL_ARCH=linux-x86_64;; \
x86) OPENSSL_ARCH=linux-elf;; \
aarch64) OPENSSL_ARCH=linux-aarch64;; \
arm*) OPENSSL_ARCH=linux-armv4;; \
@@ -45,14 +45,12 @@ RUN addgroup -g 1000 node \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \
diff --git a/node_lts-bullseye-slim/Dockerfile b/node_lts-bullseye-slim/Dockerfile
index 5d57b1c..9c773ea 100644
--- a/node_lts-bullseye-slim/Dockerfile
+++ b/node_lts-bullseye-slim/Dockerfile
@@ -3,7 +3,7 @@ FROM debian:bullseye-slim
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
@@ -27,14 +27,12 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \
diff --git a/node_lts-bullseye/Dockerfile b/node_lts-bullseye/Dockerfile
index 515a27f..74b9d74 100644
--- a/node_lts-bullseye/Dockerfile
+++ b/node_lts-bullseye/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
@@ -24,14 +24,12 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \
diff --git a/node_lts-iron/Dockerfile b/node_lts-iron/Dockerfile
index 51fdd11..4423a13 100644
--- a/node_lts-iron/Dockerfile
+++ b/node_lts-iron/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
@@ -24,14 +24,12 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \
diff --git a/node_lts-slim/Dockerfile b/node_lts-slim/Dockerfile
index bee8e81..d738839 100644
--- a/node_lts-slim/Dockerfile
+++ b/node_lts-slim/Dockerfile
@@ -3,7 +3,7 @@ FROM debian:bookworm-slim
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
-ENV NODE_VERSION 20.17.0
+ENV NODE_VERSION 20.18.0
RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
@@ -27,14 +27,12 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
141F07595B7B3FFE74309A937405533BE57C7D57 \
74F12602B6F1C4E913FAA37AD3A89613643B6201 \
DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \
- 61FC681DFB92A079F1685E77973F295594EC4689 \
+ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
- C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 \
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C \
108F52B48DB57BB0CC439B2997B01419BD92F80A \
A363A499291CBBC940DD62E41F10027AF002F8B0 \
- CC68F5A3106FF448322E48ED27F5E38D5B0A215F \
; do \
gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys "$key" || \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" ; \ Relevant Maintainers:
|
LaurentGoderre
approved these changes
Oct 4, 2024
LaurentGoderre
changed the title
Node: fix: Drop ppc64le and x390x from Bullseye
Node: fix: Version 20.18 and drop ppc64le and x390x from Bullseye
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: nodejs/docker-node#2146
@LaurentGoderre @PeterDaveHello @SimenB @Starefossen @nschonni @ttshivers