Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command/volume: various fixes and improvements in tests #5782

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

cli/command/volume: TestVolumeCreateErrors: assert unhandled errors

cli/command/volume: TestVolumeCreateWithName: minor fixes and improvements

  • assert unhandled error
  • use sub-tests
  • add test-case for conflicting options (both flag and name)
  • reset command-args to prevent test failing when running from pre-compiled test-binary
  • use a const and a slightly more unique name for the volume-name
  • discard stdout/stderr output

cli/command/volume: TestVolumeCreateWithFlags: minor fixes

  • assert unhandled error
  • reset command-args to prevent test failing when running from pre-compiled test-binary
  • use a const and a slightly more unique name for the volume-name
  • discard stdout/stderr output

cli/command/volume: TestVolumeCreateCluster: minor fixes and refactor

  • assert unhandled error
  • use sub-tests
  • use slightly more unique volume-names
  • discard stdout/stderr output

cli/command/volume: TestVolumeCreateClusterOpts: minor fixes and refactor

  • assert unhandled error
  • discard stdout/stderr output

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…ments

- assert unhandled error
- use sub-tests
- add test-case for conflicting options (both flag and name)
- reset command-args to prevent test failing when running from pre-compiled test-binary
- use a const and a slightly more unique name for the volume-name
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <[email protected]>
- assert unhandled error
- reset command-args to prevent test failing when running from pre-compiled test-binary
- use a const and a slightly more unique name for the volume-name
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <[email protected]>
- assert unhandled error
- use sub-tests
- use slightly more unique volume-names
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <[email protected]>
…ctor

- assert unhandled error
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.0 milestone Feb 1, 2025
@thaJeztah thaJeztah self-assigned this Feb 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (bdd70c1) to head (341e665).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5782   +/-   ##
=======================================
  Coverage   59.42%   59.42%           
=======================================
  Files         347      347           
  Lines       29402    29402           
=======================================
  Hits        17472    17472           
  Misses      10958    10958           
  Partials      972      972           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants