Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/registry/client: remove dependency on trust / notary #5880

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

thaJeztah
Copy link
Member

The client was only using the Actions consts, but the trust package also has a dependency on notary. Remove the import to prevent Notary becoming a dependency for uses of the cli code.

- A picture of a cute animal (not mandatory but encouraged)

The client was only using the Actions consts, but the trust package
also has a dependency on notary. Remove the import to prevent Notary
becoming a dependency for uses of the cli code.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 3, 2025
@thaJeztah
Copy link
Member Author

Looks like I forgot to include this one in #5878 - this one should also be trivial; the predefined vars are nice, but don't add much value, and we shouldn't depend on the trust code for this (more likely it should've been the other way round)

@thaJeztah thaJeztah requested review from Benehiko and a team March 3, 2025 11:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (076ec3b) to head (e3da0cc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5880   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files         353      353           
  Lines       29735    29735           
=======================================
  Hits        17637    17637           
  Misses      11117    11117           
  Partials      981      981           

@thaJeztah thaJeztah merged commit 43a2fcf into docker:master Mar 3, 2025
110 checks passed
@thaJeztah thaJeztah deleted the registry_decouple_trust branch March 3, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants