Test version command #12576
Merged
Test version command #12576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I honestly don't feel like this command requires a test... |
|
@ndeloof That's fair, I added the test because:
Please let me know what areas you'd prefer to prioritize for future tests. |
ndeloof
approved these changes
Feb 26, 2025
cmd/compose/version_test.go
Outdated
| defer func() { | ||
| internal.Version = originalVersion | ||
| }() | ||
| internal.Version = "v2.33.0-desktop.1" |
There was a problem hiding this comment.
This version string is very specific to Docker Desktop and will be outdated once we release v2.34, I fear this will bring some confusion. Better use a pure fake version for testing purpose: v9.9.9-test for example
There was a problem hiding this comment.
@ndeloof Good suggestion, done. If there are other areas you'd like unit tests prioritized, just shout.
maxproske
force-pushed
the
feature/test-version
branch
from
c32f122 to
6a993dc
Compare
ndeloof
approved these changes
Feb 26, 2025
glours
approved these changes
Feb 26, 2025
Signed-off-by: Max Proske <[email protected]>
auto-merge was automatically disabled
February 26, 2025 15:16
Head branch was pushed to by a user without write access
maxproske
force-pushed
the
feature/test-version
branch
from
6a993dc to
3fbe1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added unit tests for
docker compose versionto ensure correct formatting.