display the location of OCI or GIT Compose stack download #12595
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
print-oci-artifact-location
branch
from
15cca45 to
278455b
Compare
ndeloof
reviewed
Mar 3, 2025
pkg/remote/git.go
Outdated
| @@ -116,6 +121,9 @@ func (g gitRemoteLoader) Load(ctx context.Context, path string) (string, error) | |||
| if stat.IsDir() { | |||
| local, err = findFile(cli.DefaultFileNames, local) | |||
| } | |||
| if progress.Mode != progress.ModeQuiet && progress.Mode != progress.ModeJSON { | |||
| _, _ = fmt.Fprintf(g.dockerCli.Out(), "Your compose stack %q is stored in %q\n", strings.TrimPrefix(path, prefix), local) | |||
There was a problem hiding this comment.
this message will print for every Git remote loaded by compose, including those involved by includes
Maybe better load project, then check if project.ComposeFiles[0] is remote then print result of Dir(".") as location where remote stack has been stored on disk
glours
force-pushed
the
print-oci-artifact-location
branch
from
278455b to
e67d8b8
Compare
ndeloof
reviewed
Mar 3, 2025
cmd/compose/up.go
Outdated
| func displayLocationRemoteStack(dockerCli command.Cli, project *types.Project, options buildOptions) { | ||
| mainComposeFile := options.ProjectOptions.ConfigPaths[0] | ||
| if ui.Mode != ui.ModeQuiet && ui.Mode != ui.ModeJSON { | ||
| if strings.HasPrefix(mainComposeFile, remote.OciPrefix) || strings.HasPrefix(mainComposeFile, "git://") { |
There was a problem hiding this comment.
Better use remote.Accept as Git support has a bunch of corner cases
glours
force-pushed
the
print-oci-artifact-location
branch
from
e67d8b8 to
684184c
Compare
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
print-oci-artifact-location
branch
from
684184c to
7e8650a
Compare
ndeloof
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Display a message with the location where the OCI artifact or GIT Compose stack were downloaded
Related issue
https://docker.atlassian.net/browse/APCLI-881
(not mandatory) A picture of a cute animal, if possible in relation to what you did
