[master] Add CentOS Stream 10. #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Nov 13, 2024
rpm/centos-10/Dockerfile
Outdated
Comment on lines
23
to
29
| # RHEL8 / CentOS 8 changed behavior and no longer "rpm --import" or | ||
| # "rpmkeys --import"as part of rpm package's %post scriplet. See | ||
| # https://forums.centos.org/viewtopic.php?f=54&t=72574, and | ||
| # https://access.redhat.com/solutions/3720351 | ||
| RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial | ||
| RUN dnf install -y rpm-build rpmlint dnf-plugins-core | ||
| RUN dnf config-manager --set-enabled crb |
There was a problem hiding this comment.
Looks like some changes are needed;
> [stage-1 2/8] RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial:
0.180 error: /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial: import read failed(2).
------
Dockerfile:27
--------------------
25 | # https://forums.centos.org/viewtopic.php?f=54&t=72574, and
26 | # https://access.redhat.com/solutions/3720351
27 | >>> RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
28 | RUN dnf install -y rpm-build rpmlint dnf-plugins-core
29 | RUN dnf config-manager --set-enabled crb
--------------------
ERROR: failed to solve: process "/bin/sh -c rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial" did not complete successfully: exit code: 1
make[1]: *** [Makefile:97: centos-10] Error 1
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-1104/rpm'
make: *** [Makefile:79: centos-10] Error 2
script returned exit code 2
There was a problem hiding this comment.
docker run --rm quay.io/centos/centos:stream10-development ls -l /etc/pki/rpm-gpg/
total 8
-rw-r--r-- 1 root root 2182 Sep 30 20:00 RPM-GPG-KEY-CentOS-SIG-Extras-SHA512
-rw-r--r-- 1 root root 1683 Sep 30 20:00 RPM-GPG-KEY-centosofficial-SHA256There was a problem hiding this comment.
One more failure; looks like rpmlint is no more for CentOS Stream 10 ("CS10");
thaJeztah
force-pushed
the
carry_centos_10
branch
2 times, most recently
from
e21ba0c
to
d130e47
Compare
laurazard
approved these changes
Nov 13, 2024
|
I'll rebase this one and remove the mention of the removal of |
Use image "stream10-development" for now, after the release we should remove the "-development" suffix. Signed-off-by: Romain Geissler <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
carry_centos_10
branch
from
d130e47
to
beae632
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use image "stream10-development" for now, after the release we should remove the "-development" suffix.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)