Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another attempt to implement saving multiple images #2050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Another attempt to implement saving multiple images #2050

wants to merge 1 commit into from

Conversation

EFanZh
Copy link

@EFanZh EFanZh commented Jun 5, 2018 •
edited
Loading

This pull request is based on #1767, and with tests fixed.

@EFanZh EFanZh mentioned this pull request Jun 5, 2018
Open
@EFanZh EFanZh closed this Jul 30, 2019
@EFanZh EFanZh deleted the save-images branch July 30, 2019 01:46
@EFanZh EFanZh restored the save-images branch July 30, 2019 01:48
@EFanZh EFanZh reopened this Jul 30, 2019
@EFanZh
Copy link
Author

EFanZh commented Aug 4, 2019

Hi @ulyssessouza, the pull request #1767 seems inactive for quite some time, can you check this PR insead?

@EFanZh EFanZh mentioned this pull request Aug 4, 2019
Open
feliperuhland
feliperuhland approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@feliperuhland feliperuhland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and looks good.

@feliperuhland
Copy link
Contributor

@shin- can you review this PR?

@feliperuhland feliperuhland mentioned this pull request Jan 11, 2020
Open
@kim0
Copy link

kim0 commented Jun 24, 2020

Hello @shin- .. Any hope to get this merged soon please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliperuhland feliperuhland feliperuhland approved these changes

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EFanZh @feliperuhland @kim0