Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StandardRegistry name for RAM #33

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

twelsh-aw
Copy link
Contributor

@twelsh-aw twelsh-aw commented Aug 26, 2024

Description

This got undone as part of our re-name in this provider 😅

Relations

Closes #32

References

Output from Acceptance Testing

% make testacc TESTS=TestAccOrgSetting
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run='TestAccOrgSetting'  -timeout 120m
?       github.com/docker/terraform-provider-docker     [no test files]
?       github.com/docker/terraform-provider-docker/internal/pkg/hubclient      [no test files]
?       github.com/docker/terraform-provider-docker/internal/pkg/repositoryutils        [no test files]
=== RUN   TestAccOrgSettingImageAccessManagement
--- PASS: TestAccOrgSettingImageAccessManagement (4.38s)
=== RUN   TestAccOrgSettingRegistryAccessManagement
--- PASS: TestAccOrgSettingRegistryAccessManagement (5.94s)
PASS
ok      github.com/docker/terraform-provider-docker/internal/provider   10.859s

This got undone as part of our re-name in this provider 😅
@twelsh-aw twelsh-aw force-pushed the fix_32 branch 3 times, most recently from b719827 to 5d0ad74 Compare August 26, 2024 20:46
@twelsh-aw twelsh-aw marked this pull request as ready for review August 26, 2024 21:47
@twelsh-aw twelsh-aw requested a review from a team as a code owner August 26, 2024 21:47
Copy link
Contributor

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@twelsh-aw twelsh-aw merged commit 41ff7c6 into docker:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TestAccOrgSettingRegistryAccessManagement fails on workflow_dispatch Acceptance Tests
3 participants