setup a docker_org_team data source #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's acceptable to create a dummy resource during test setup code for a data source test. e.g https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/s3/bucket_data_source_test.go#L110 Ideally we aren't relying too much on pre-configured things and writing something that works in any environment. |
|
@twelsh-aw i'm fine to do that for a majority of resources, but there are some (eg: user) where it can get difficult |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes a data source for docker_org_team, still need to write tests...
In order for a lot of these tests (especially data sources) it may be good to write testing resources in infra-terraform so we know which resources are long-living that can be called.
Relations
Closes #48