Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file mounts (work dir change) and python reloading #311

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mikesir87
Copy link
Member

Recent versions of Flask don't do the automatic restart even with debug turned on and require watchdog to be installed. I ended up creating another stage that does this and updated the Compose file to use that stage as the target.

Also fixed file mount changes, due to the recent working directory changes (oops!)

@github-actions
Copy link

Docker image tag(s) pushed:

ghcr.io/dockersamples/example-voting-app-vote:pr-311
dockersamples/examplevotingapp_vote:pr-311

Labels added to images:

org.opencontainers.image.created=2023-10-27T17:58:03.035Z
org.opencontainers.image.description=Example distributed app composed of multiple containers for Docker, Compose, Swarm, and Kubernetes
org.opencontainers.image.licenses=Apache-2.0
org.opencontainers.image.revision=19e97176be3cd045a66ed1b3d401f43490e9c2bb
org.opencontainers.image.source=https://github.com/dockersamples/example-voting-app
org.opencontainers.image.title=example-voting-app
org.opencontainers.image.url=https://github.com/dockersamples/example-voting-app
org.opencontainers.image.version=pr-311

@mikesir87 mikesir87 merged commit 8b0f5ad into main Oct 27, 2023
1 check passed
@mikesir87 mikesir87 deleted the fix-python-reloading branch October 27, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant