Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to use local storage instead of cookies #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add option to use local storage instead of cookies #200

wants to merge 1 commit into from

Conversation

YulianMoreno
Copy link
Contributor

It is an interesting option if you do not need the data in all the requests

@stuyam
Copy link
Contributor

stuyam commented May 19, 2022

I like this idea, one thing I don't love is that the class is still called Cookie, I would love to either make a more generic name for the classes like DataStore or something or call one Cookie and one Storage and change the code in the build process depending on which one gets loaded or something. Just brainstorming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YulianMoreno @stuyam