Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support dark mode for zoom-image plugin #2524

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

sy-records
Copy link
Member

Summary

  • Support dark mode for zoom-image plugin.
  • Add z-index, Fix:
image

Related issue, if any:

Fix #2508

What kind of change does this PR introduce?

Feature

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Yes
No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@sy-records sy-records requested a review from a team January 3, 2025 06:48
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 6:49am

Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sy-records , this is a fantastic enhancement for the zoom-image plugin, esp. for Docsify v5🙂 I've tested locally and the results look good!

2025-01-03_10-33-08 2025-01-03_10-33-28

Thanks again! Paul

@sy-records sy-records requested a review from a team January 4, 2025 02:34
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sy-records sy-records merged commit 5826863 into docsifyjs:develop Jan 5, 2025
9 checks passed
@sy-records sy-records deleted the feat/zoom-image branch January 5, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Support dark mode for zoom-image plugin
3 participants