Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for dependencies injection and Symfony 7 #559

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

MrYamous
Copy link
Contributor

@MrYamous MrYamous commented Nov 7, 2024

Related to #521
Update doc to mention this interface is no longer available starting from SF 7+
Considering this bundle can be used with older versions I think this isn't necessary to remove this part as it can be useful for some projects

Comment on lines 302 to 303
The interface ``Symfony\Component\DependencyInjection\ContainerAwareInterface`` has been deprecated in Symfony 6.4 and
removed in 7.0. If you use this version or newer, there is currently no way to inject dependencies in migrations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be nit-picking here, but there has never been a way to inject dependencies into migrations. It was the service container that was injected.

@MrYamous
Copy link
Contributor Author

MrYamous commented Nov 7, 2024

Updated according to Derrabus review

@greg0ire greg0ire requested a review from derrabus November 7, 2024 22:10
Resources/doc/index.rst Outdated Show resolved Hide resolved
@derrabus derrabus merged commit f51a03e into doctrine:3.3.x Nov 8, 2024
10 checks passed
@derrabus derrabus added this to the 3.3.2 milestone Nov 8, 2024
@MrYamous MrYamous deleted the docs/di-migration-symfony7 branch November 8, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants