Display Doctrine deprecations when running PHPUnit #11807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give a signal that there is work to be done without blocking other contributions by failing the build.
greg0ire
commented
Jan 25, 2025
| @@ -643,7 +644,7 @@ public function testCountQueryStripsParametersInSelect(): void | |||
| self::assertCount(2, $getCountQuery->invoke($paginator)->getParameters()); | |||
| self::assertCount(9, $paginator); | |||
|
|
|||
| $query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, SqlWalker::class); | |||
| $query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, SqlOutputWalker::class); | |||
There was a problem hiding this comment.
This is the only difference with 4.0.x in this method.
derrabus
approved these changes
Jan 25, 2025
greg0ire
commented
Jan 25, 2025
| @@ -67,5 +68,12 @@ | |||
| <var name="privileged_db_port" value="3306"/> | |||
| --> | |||
| <env name="COLUMNS" value="120"/> | |||
| <env name="DOCTRINE_DEPRECATIONS" value="trigger"/> | |||
There was a problem hiding this comment.
I used env rather than server as described in https://github.com/doctrine/deprecations/?tab=readme-ov-file#displaying-deprecations-after-running-a-phpunit-test-suite for the sake of consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give a signal that there is work to be done without blocking other contributions by failing the build.