Break OvertypedType
-> BlockVariable
-> OverloadedType
reference cycle
#194
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
weakref
forOverloadedType.block_variable
, accessed indirectly via aproperty
. The result persists for as long as it is used elsewhere (e.g. on the tape, referenced by aControl
, etc).Example use:
First line creates and then immediately destroys a
BlockVariable
. Second line creates anotherBlockVariable
, holding a reference to it, so that the third line references the sameBlockVariable
. Net effect: attach a newBlockVariable
toot
, hold two references onobject_0
andobject_1
, hold a weak reference onot
.Could be optimized by adding an
OverloadedType.clear_block_variable
method to replace the first line of the above examplewhich avoids the creation and immediate destruction of a
BlockVariable
.