Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
fulghum committed Feb 4, 2025
1 parent f06b307 commit 8adf532
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go/store/nbs/journal_record.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,13 +292,13 @@ func processJournalRecords(ctx context.Context, r io.ReadSeeker, off int64, cb f

// TODO: The NomsBlockStore manifest is updated when the sql engine is shutdown cleanly. In the clean shutdown
// case, we have the root hash value and the number of chunks written to the journal from the manifest
// and we could use that that more aggressively validate journal records. When we are starting up from a
// and we could use that to more aggressively validate journal records. When we are starting up from a
// clean shutdown, we expect all journal records to be valid, and could safely error out during startup
// for invalid records.
if validationErr := validateJournalRecord(buf); validationErr != nil {
// NOTE: We don't assign the validation error to err, because we want to stop processing journal records
// when we see an invalid record and return successfully from processJournalRecords(), so that only
// the preceding records in the journal are used.
// the preceding, valid records in the journal are used.
logrus.Errorf("Error validating journal record; "+
"skipping remaining journal records past offset %d: %s", off, validationErr)
break
Expand Down

0 comments on commit 8adf532

Please sign in to comment.