Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] go: store/nbs: GhostBlockStore: Add refCheck which participates in updating hasRecords. #8811

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 4, 2025

Fixes a bug in the current implementation of GenerationalNBS.refCheck where things that are found in the GhostBlockStore are not marked in the hasRecords as being found.

… participates in updating hasRecords.

Fixes a bug in the current implementation of GenerationalNBS.refCheck
where things that are found in the GhostBlockStore are not marked
in the hasRecords as being found.
@reltuk reltuk requested a review from macneale4 February 4, 2025 20:06
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
56b42c9 ok 5937457
version total_tests
56b42c9 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a279a81 ok 5937457
version total_tests
a279a81 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 568590e into main Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants