Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kvexec] fix left join nullability bug #8812

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[kvexec] fix left join nullability bug #8812

merged 1 commit into from
Feb 4, 2025

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Feb 4, 2025 •
edited
Loading

We were using a stale variable for a nullability comparison.

test here: dolthub/go-mysql-server#2840

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
778e5e1 ok 5937457
version total_tests
778e5e1 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit 094fc7b into main Feb 4, 2025
34 of 35 checks passed
@max-hoffman max-hoffman deleted the max/left-join-nullability-bug branch February 4, 2025 22:05
@BrewTestBot BrewTestBot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-hoffman @coffeegoddd @zachmu