Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for encoding extended types in keys #8817

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Feb 5, 2025

This PR allows certain Doltgres extended types to be correctly serialized as part of keys

@zachmu zachmu requested a review from Hydrocharged February 5, 2025 02:00
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4398e55 ok 5937457
version total_tests
4398e55 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9a2e242 ok 5937457
version total_tests
9a2e242 5937457
correctness_percentage
100.0

Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hydrocharged
Copy link
Contributor

Related to dolthub/doltgresql#1171 (for the failing integration test)

@zachmu zachmu merged commit 9e36f51 into main Feb 5, 2025
20 of 22 checks passed
Copy link

github-actions bot commented Feb 6, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.08 1.5
blob 1 blob 200000 1 0.88 3.99 4.73
blob 2 blobs 200000 1 0.91 4.32 4.82
blob no blob 200000 1 0.94 2.32 2.71
col type datetime 200000 1 0.8 2.5 2.86
col type varchar 200000 1 0.75 3.12 3.55
config width 2 cols 200000 1 0.77 2.56 4.57
config width 32 cols 200000 1 1.88 2.05 2.79
config width 8 cols 200000 1 0.96 2.43 2.78
pk type float 200000 1 0.85 2.38 2.68
pk type int 200000 1 0.87 2.31 2.6
pk type varchar 200000 1 1.5 1.72 1.86
row count 1.6mm 1600000 1 5.66 2.96 2.92
row count 400k 400000 1 1.49 2.74 2.87
row count 800k 800000 1 2.9 2.86 2.87
secondary index four index 200000 1 3.58 1.41 1.28
secondary index no secondary 200000 1 1.02 2.14 2.54
secondary index one index 200000 1 1.11 2.48 2.59
secondary index two index 200000 1 1.99 1.74 1.88
sorting shuffled 1mm 1000000 0 5.17 2.78 2.64
sorting sorted 1mm 1000000 1 4.99 2.88 2.75

Copy link

github-actions bot commented Feb 6, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.23
dolt_blame_commit_filter system table 2.98
dolt_commit_ancestors_commit_filter system table 0.61
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.8
dolt_diff_log_join_to_commit system table 2.75
dolt_diff_table_from_commit_filter system table 1.2
dolt_diff_table_to_commit_filter system table 1.18
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.27
dolt_log_commit_filter system table 1.1

Copy link

github-actions bot commented Feb 6, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.12
adds_updates_deletes 60000 60000 60000 4.48
deletes_only 0 60000 0 2.41
updates_only 0 0 60000 2.99

@Hydrocharged Hydrocharged deleted the zachmu/extended-encoding branch February 6, 2025 09:41
Copy link

github-actions bot commented Feb 7, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.1 1.2
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.91 3.86 4.62
blob 2 blobs 200000 1 0.94 4.24 4.67
blob no blob 200000 1 1.07 2.06 2.43
col type datetime 200000 1 0.85 2.38 2.68
col type varchar 200000 1 0.8 3 3.33
config width 2 cols 200000 1 0.96 2.09 2.49
config width 32 cols 200000 1 1.89 2.06 2.74
config width 8 cols 200000 1 0.98 2.36 2.88
pk type float 200000 1 0.85 2.4 2.72
pk type int 200000 1 0.81 2.48 2.83
pk type varchar 200000 1 2.86 0.91 0.96
row count 1.6mm 1600000 1 5.67 2.98 2.95
row count 400k 400000 1 1.57 2.65 2.76
row count 800k 800000 1 2.93 2.85 2.85
secondary index four index 200000 1 3.57 1.39 1.32
secondary index no secondary 200000 1 1.07 2.07 2.42
secondary index one index 200000 1 1.18 2.35 2.48
secondary index two index 200000 1 2.05 1.73 1.82
sorting shuffled 1mm 1000000 0 5.15 2.85 2.77
sorting sorted 1mm 1000000 1 5 2.93 2.8

Copy link

github-actions bot commented Feb 7, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.22
dolt_blame_commit_filter system table 2.98
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 2.82
dolt_diff_log_join_to_commit system table 2.8
dolt_diff_table_from_commit_filter system table 1.2
dolt_diff_table_to_commit_filter system table 1.16
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.28
dolt_log_commit_filter system table 1.1

Copy link

github-actions bot commented Feb 7, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.13
adds_updates_deletes 60000 60000 60000 4.75
deletes_only 0 60000 0 2.48
updates_only 0 0 60000 3.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants