[no-release-notes] go: sqle: dolt_gc: Purge read caches associated with the DoltDB as we begin GC. #8858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the DoltDB as we begin GC. The right place to do this is in the safepoint controller, at BeginGC. We need to do it after keeperFunc is installed on the NomsBlockStore, so that all read dependencies are taken. We also need to do it before we register all sessions whose cached state we need to visit.
|
@coffeegoddd DOLT
|
… rely on a safepoint controller to do it.
|
@coffeegoddd DOLT
|
zachmu
approved these changes
Feb 13, 2025
| @@ -49,6 +49,8 @@ type NodeStore interface { | |||
|
|
|||
| BlobBuilder() *BlobBuilder | |||
| PutBlobBuilder(*BlobBuilder) | |||
|
|
|||
| PurgeCaches() | |||
…ss improvements on KillConnection safepoint controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right place to do this is in the safepoint controller, at BeginGC. We need to do it after keeperFunc is installed on the NomsBlockStore, so that all read dependencies are taken. We also need to do it before we register all sessions whose cached state we need to visit.