functions: add more pure functions

Updates gh-149
dominikh · Aug 6, 2017 · 7701ff7 · 7701ff7
1 parent 2ab10e4
commit 7701ff7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/functions/functions.go b/functions/functions.go
@@ -11,6 +11,14 @@ import (
 )
 
 var stdlibDescs = map[string]Description{
+	"errors.New": Description{Pure: true},
+
+	"fmt.Errorf":  Description{Pure: true},
+	"fmt.Sprintf": Description{Pure: true},
+	"fmt.Sprint":  Description{Pure: true},
+
+	"sort.Reverse": Description{Pure: true},
+
 	"strings.Map":            Description{Pure: true},
 	"strings.Repeat":         Description{Pure: true},
 	"strings.Replace":        Description{Pure: true},

diff --git a/staticcheck/testdata/CheckUnsafePrintf.go b/staticcheck/testdata/CheckUnsafePrintf.go
@@ -8,10 +8,10 @@ import (
 func fn() {
 	var s string
 	fn2 := func() string { return "" }
-	fmt.Printf(fn2())  // MATCH /should use print-style function/
-	fmt.Sprintf(fn2()) // MATCH /should use print-style function/
-	log.Printf(fn2())  // MATCH /should use print-style function/
-	fmt.Printf(s)      // MATCH /should use print-style function/
+	fmt.Printf(fn2())      // MATCH /should use print-style function/
+	_ = fmt.Sprintf(fn2()) // MATCH /should use print-style function/
+	log.Printf(fn2())      // MATCH /should use print-style function/
+	fmt.Printf(s)          // MATCH /should use print-style function/
 	fmt.Printf(s, "")
 
 	fmt.Printf(fn2(), "")