Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck: flag dubious bit shifting of fixed size integers #693

Closed
wants to merge 6 commits into from
Closed

staticcheck: flag dubious bit shifting of fixed size integers #693

wants to merge 6 commits into from

Conversation

ksurent
Copy link
Contributor

@ksurent ksurent commented Feb 9, 2020

Fixes #654. Refers #149.

dominikh
dominikh requested changes May 10, 2020
View reviewed changes
Copy link
Owner

@dominikh dominikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some straightforward changes.

staticcheck/doc.go Outdated Show resolved Hide resolved
staticcheck/doc.go Outdated Show resolved Hide resolved
staticcheck/doc.go Outdated Show resolved Hide resolved
staticcheck/lint.go Outdated Show resolved Hide resolved
staticcheck/lint.go Outdated Show resolved Hide resolved
staticcheck/lint.go Outdated Show resolved Hide resolved
staticcheck/lint.go Outdated Show resolved Hide resolved
staticcheck/lint.go Outdated Show resolved Hide resolved
@ksurent
Copy link
Contributor Author

ksurent commented May 16, 2020

Feedback addressed.
Not sure about the CI failure, tests pass on my laptop. Should I rebase onto the latest master, perhaps?

@dominikh
Copy link
Owner

You can rebase if you want to, but it will require some code changes, due to 9a1fe45. I'd be happy to rebase it for you.

@ksurent
Copy link
Contributor Author

ksurent commented May 16, 2020

Please do!

@dominikh
Copy link
Owner

Merged as e306c66. Thank you!

@dominikh dominikh closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikh dominikh dominikh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

staticcheck: (type SA9???) Check if static bit shifts will always clear a value
2 participants
@ksurent @dominikh