Merge pull request #115 from domodwyer/dependabot/cargo/pest_derive-2… #241
Annotations
12 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L98
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:98:37
|
98 | print_types(&mut out, &ast, &self.derive.as_str())?;
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.derive.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
use of a fallible conversion when an infallible one could be used:
src/ast/mod.rs#L117
warning: use of a fallible conversion when an infallible one could be used
--> src/ast/mod.rs:117:24
|
117 | Node::Type(BasicType::try_from(ast.as_str()).expect("unrecognised type"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: converting `&str` to `BasicType` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
help: use
|
117 - Node::Type(BasicType::try_from(ast.as_str()).expect("unrecognised type"))
117 + Node::Type(BasicType::from(ast.as_str()))
|
|
use of a fallible conversion when an infallible one could be used:
src/ast/mod.rs#L97
warning: use of a fallible conversion when an infallible one could be used
--> src/ast/mod.rs:97:28
|
97 | if let Ok(t) = BasicType::try_from(ast.as_str()) {
| ^^^^^^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `&str` to `BasicType` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
use of `unwrap_or_else` to construct default value:
src/ast/array.rs#L66
warning: use of `unwrap_or_else` to construct default value
--> src/ast/array.rs:66:14
|
66 | .unwrap_or_else(|| "".to_string());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
name `EOF` contains a capitalized acronym:
src/ast/node.rs#L23
warning: name `EOF` contains a capitalized acronym
--> src/ast/node.rs:23:5
|
23 | EOF,
| ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
this lifetime isn't used in the impl:
src/ast/basic_type.rs#L82
warning: this lifetime isn't used in the impl
--> src/ast/basic_type.rs:82:6
|
82 | impl<'a> From<String> for BasicType {
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
|
this lifetime isn't used in the impl:
src/ast/basic_type.rs#L59
warning: this lifetime isn't used in the impl
--> src/ast/basic_type.rs:59:6
|
59 | impl<'a> std::fmt::Display for BasicType {
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
|
this lifetime isn't used in the impl:
src/ast/basic_type.rs#L15
warning: this lifetime isn't used in the impl
--> src/ast/basic_type.rs:15:6
|
15 | impl<'a> BasicType {
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|