Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Updates from Issue #1002 #1086

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Style Updates from Issue #1002 #1086

merged 7 commits into from
Jan 30, 2024

Conversation

ceciliazaragoza
Copy link
Collaborator

@ceciliazaragoza ceciliazaragoza commented Jan 24, 2024 •
edited
Loading

Pull Request Checklist

  • Travis C.I. build passes
  • All five Demos look as expected when loaded
  • Reload works as expected
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Loading a network from the database looks as expected when loaded
  • Import works for both SIF and GraphML
  • Graph can be exported to SIF, GraphML and Excel
  • Graph can be exported to PNG, SVG and PDF
  • Expression data and Additional Sheets can be exported to Excel
  • Print works as expected
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Enabling and disabling node coloring works as expected
  • Node coloring options work as expected (selection top/bottom dataset, averaging values, changing max value)
  • Weighted graph loaded with the "Enable Edge Coloring" option checked appears as expected
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)
  • D-pad left/right/top/bottom/center works as expected
  • Zoom slider changes number and has effect on graph (viewport and menu)
  • Right click on a node opens gene page, page is populated with correct data

@ceciliazaragoza
attempted to solve toString() redundancy, unnecessary eslint-diable c…
4beab33 
…omment, changed a variable from x to gene to make it more clear what info the variable contains, reduced indentation by creating another method called expressionDataHandler, and created another function called expressionExportErrorHandler to reduce code repetition
@ceciliazaragoza
working on issue #1002. ran npm lint and revised method call for expr…
0dab0ff 
…essionDataHandler to be expressionDataHandler(expressionData, sheet, route, extension, sheetType, finalExportSheets) so that method gets all necessary info and fixed indentation in expressionExportErrorHandler.
@ceciliazaragoza
Working on issue #1002. Fixed the verbose code with x !== false, fixe…
93d9033 
…d the inconsistent function style by making 2 functions next to each other both arrow functions, and changed the variable x to connection for clarity
@ceciliazaragoza
Issue #1002. Removed and fixed lingering /* eslint-disable max-len */…
895f8f6 
… comment in server/dals/protein-dal.js
@ceciliazaragoza
Issue #1002. Worked on redundant code, made createMatrix method in ge…
3602342 
…nerate_network.py
@ceciliazaragoza
added createMatrix method to generate_new_network_version.py. adjuste…
33eb3b6 
…d createMatrix method in generate_network.py and generate_new_network.py to remove redundancy of if result != False
@ceciliazaragoza
On Issue #1002, removing my package-lock.json from pull request since…
e9c3755 
… does not need to be pushed
@ceciliazaragoza ceciliazaragoza self-assigned this Jan 30, 2024
@ceciliazaragoza
Copy link
Collaborator Author

ceciliazaragoza commented Jan 30, 2024 •
edited
Loading

  • Import works for both SIF and GraphML

dondi
dondi approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dondi dondi merged commit 93bc5e1 into beta Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondi dondi dondi approved these changes

Assignees

@ceciliazaragoza ceciliazaragoza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceciliazaragoza @dondi