#1080: Display warning when node coloring enabled for PPIs #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring is clicked and viewing a PPI. Want to change so that Warnings List is already collapsed and can view warning message immediately. Also found issue where Can enable node coloring from left panel with PPI but not with navbar menu
…d nodeColoringEnabled.
…Is, but need to make sure node coloring sidebar not disabled when first load PPI and that don't get long list of console warnings when load PPI the first time
… for PPIs to be in warnings list
dondi
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Looks good from a code-review perspective—for changes like these, the code review mainly looks at style and localized approaches instead of full functionality. We’ll definitely still want to put this through its paces to make sure that the fix truly does what it’s intended
| } | ||
| refreshApp(); |
There was a problem hiding this comment.
As you might have observed, “refresh” calls are not expressly needed in frameworks like React and SwiftUI—but they still do happen. It is, in fact, part of what these frameworks offer that certain operations are done automatically and at the right moments, rather than leaving it to the programmer to make it happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1080. When user viewing and PPI and node coloring enabled in navbar or sidebar, warning modal displays to let users know they are displaying mRNA-level expression data on a PPI network.