Faster bitwise-equal weld() implementation #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an alternative
weld()
implementation based on Meshoptimizer's approach. When tolerance=0, we use a hashtable to find bitwise-equal vertices quickly. This is vastly faster than previous approaches, but comes without tolerance options. When tolerance is non-zero,weld()
falls back on the older implementation. In v4.0, the new implementation will be the default.Results
Context
Tasks
debug performance regression above. hash collisions maybe?