Fix migrations

dorssel · Mar 1, 2024 · d67895e · d67895e
1 parent 0c03330
commit d67895e
Show file tree

Hide file tree

Showing 9 changed files with 119 additions and 22 deletions.
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
   "version": 1,
   "isRoot": true,
   "tools": {
@@ -7,4 +8,4 @@
       "commands": ["dotnet-ef"]
     }
   }
-}
+}
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -9,15 +9,15 @@ SPDX-License-Identifier: MIT
     <!-- all -->
     <PackageVersion Include="GitVersion.MsBuild" Version="5.12.0" />
     <!-- SqliteTimestamp -->
-    <PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.2" />
-    <PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.2" />
     <PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.2" />
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
     <!-- unit tests -->
+    <PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.2" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
     <PackageVersion Include="MSTest.TestAdapter" Version="3.2.2" />
     <PackageVersion Include="MSTest.TestFramework" Version="3.2.2" />
-    <PackageVersion Include="Moq" Version="4.20.70" />
     <PackageVersion Include="coverlet.collector" Version="6.0.1" />
+    <!-- Example -->
+    <PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.2" />
   </ItemGroup>
 </Project>
diff --git a/Example/Example.csproj b/Example/Example.csproj
@@ -15,7 +15,6 @@ SPDX-License-Identifier: MIT
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/SqliteTimestamp/SqliteTimestamp.csproj b/SqliteTimestamp/SqliteTimestamp.csproj
@@ -11,7 +11,6 @@ SPDX-License-Identifier: MIT
     <AssemblyName>Dorssel.EntityFrameworkCore.Sqlite.Timestamp</AssemblyName>
 
     <IsPackable>true</IsPackable>
-    <GenerateRuntimeConfigurationFiles>false</GenerateRuntimeConfigurationFiles>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageId>Dorssel.EntityFrameworkCore.Sqlite.Timestamp</PackageId>
     <SignAssembly>true</SignAssembly>
@@ -23,10 +22,6 @@ SPDX-License-Identifier: MIT
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Design">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
   </ItemGroup>

diff --git a/SqliteTimestamp/SqliteTimestampMigrationsSqlGenerator.cs b/SqliteTimestamp/SqliteTimestampMigrationsSqlGenerator.cs
@@ -32,16 +32,19 @@ public override IReadOnlyList<MigrationCommand> Generate(IReadOnlyList<Migration
         {
             switch (operation)
             {
-                case TableOperation tableOperation:
-                    if (operation is RenameTableOperation renameTableOperation)
-                    {
-                        tablesAffected.Add(new(renameTableOperation.NewName ?? renameTableOperation.Name, renameTableOperation.NewSchema));
-                    }
-                    tablesAffected.Add(new(tableOperation.Name, tableOperation.Schema));
+                case CreateTableOperation createTableOperation:
+                    tablesAffected.Add(new(createTableOperation.Name, createTableOperation.Schema));
                     break;
-
-                case ColumnOperation columnOperation:
-                    tablesAffected.Add(new(columnOperation.Table, columnOperation.Schema));
+                case AlterTableOperation alterTableOperation:
+                    tablesAffected.Add(new(alterTableOperation.Name, alterTableOperation.Schema));
+                    tablesAffected.Add(new(alterTableOperation.OldTable.Name, alterTableOperation.OldTable.Schema));
+                    break;
+                case RenameTableOperation renameTableOperation:
+                    tablesAffected.Add(new(renameTableOperation.NewName ?? renameTableOperation.Name, renameTableOperation.NewSchema));
+                    tablesAffected.Add(new(renameTableOperation.Name, renameTableOperation.Schema));
+                    break;
+                case DropTableOperation dropTableOperation:
+                    tablesAffected.Add(new(dropTableOperation.Name, dropTableOperation.Schema));
                     break;
             }
         }

diff --git a/UnitTests/SqliteTimestampMigrationsSqlGenerator_Tests.cs b/UnitTests/SqliteTimestampMigrationsSqlGenerator_Tests.cs
@@ -2,16 +2,102 @@
 //
 // SPDX-License-Identifier: MIT
 
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Metadata;
+using Microsoft.EntityFrameworkCore.Migrations;
+using Microsoft.EntityFrameworkCore.Migrations.Operations;
+
 namespace UnitTests;
 
 [TestClass]
 sealed class SqliteTimestampMigrationsSqlGenerator_Tests
 {
     [TestMethod]
-    public void SqliteTimestampMigrationsSqlGenerator_Create()
+    public void SqliteTimestampMigrationsSqlGenerator_CreateTable()
+    {
+        using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
+        var designTimeModel = db.GetService<IDesignTimeModel>();
+        var operations = new List<MigrationOperation>
+        {
+            new CreateTableOperation() { Name = MemoryDbContext.TestTableName }
+        };
+
+        var result = generator.Generate(operations, designTimeModel.Model);
+
+        Assert.IsTrue(result.Any(c => c.CommandText.Contains("TRIGGER")));
+    }
+
+    [TestMethod]
+    public void SqliteTimestampMigrationsSqlGenerator_RenameTable()
+    {
+        using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
+        var designTimeModel = db.GetService<IDesignTimeModel>();
+        var operations = new List<MigrationOperation>
+        {
+            new RenameTableOperation() { Name = MemoryDbContext.TestTableName, NewName = "Renamed" }
+        };
+
+        var result = generator.Generate(operations, designTimeModel.Model);
+
+        Assert.IsTrue(result.Any(c => c.CommandText.Contains("TRIGGER")));
+    }
+
+    [TestMethod]
+    public void SqliteTimestampMigrationsSqlGenerator_RenameSchema()
+    {
+        using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
+        var designTimeModel = db.GetService<IDesignTimeModel>();
+        var operations = new List<MigrationOperation>
+        {
+            new RenameTableOperation() { Name = MemoryDbContext.TestTableName, NewSchema = "Renamed" }
+        };
+
+        var result = generator.Generate(operations, designTimeModel.Model);
+
+        Assert.IsTrue(result.Any(c => c.CommandText.Contains("TRIGGER")));
+    }
+
+    [TestMethod]
+    public void SqliteTimestampMigrationsSqlGenerator_AlterTable()
+    {
+        using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
+        var designTimeModel = db.GetService<IDesignTimeModel>();
+        var operations = new List<MigrationOperation>
+        {
+            new AlterTableOperation() { Name = MemoryDbContext.TestTableName }
+        };
+
+        var result = generator.Generate(operations, designTimeModel.Model);
+
+        Assert.IsTrue(result.Any(c => c.CommandText.Contains("TRIGGER")));
+    }
+
+    [TestMethod]
+    public void SqliteTimestampMigrationsSqlGenerator_DropTable()
+    {
+        using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
+        var designTimeModel = db.GetService<IDesignTimeModel>();
+        var operations = new List<MigrationOperation>
+        {
+            new DropTableOperation() { Name = MemoryDbContext.TestTableName }
+        };
+
+        var result = generator.Generate(operations, designTimeModel.Model);
+
+        Assert.IsTrue(result.Any(c => c.CommandText.Contains("TRIGGER")));
+    }
+
+    [TestMethod]
+    public void SqliteTimestampMigrationsSqlGenerator_NullModelNoThrow()
     {
         using var db = new MemoryDbContext();
+        var generator = db.GetService<IMigrationsSqlGenerator>();
 
-        db.Database.EnsureCreated();
+        _ = generator.Generate([]);
     }
 }
diff --git a/UnitTests/UnitTests.csproj b/UnitTests/UnitTests.csproj
@@ -14,7 +14,6 @@ SPDX-License-Identifier: MIT
   <ItemGroup>
     <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
-    <PackageReference Include="Moq" />
     <PackageReference Include="MSTest.TestAdapter" />
     <PackageReference Include="MSTest.TestFramework" />
     <PackageReference Include="coverlet.collector" />

diff --git a/codecov.yml b/codecov.yml
@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: 2024 Frans van Dorsselaer
+#
+# SPDX-License-Identifier: MIT
+
+---
+coverage:
+  status:
+    patch:
+      default:
+        informational: true
+    project:
+      default:
+        informational: true
diff --git a/dotnet-ef-sqlite-timestamp.sln b/dotnet-ef-sqlite-timestamp.sln
@@ -13,6 +13,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		.gitattributes = .gitattributes
 		.gitignore = .gitignore
 		.mega-linter.yml = .mega-linter.yml
+		codecov.yml = codecov.yml
 		Directory.Build.props = Directory.Build.props
 		Directory.Packages.props = Directory.Packages.props
 		GitVersion.yml = GitVersion.yml