Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starter): Issue 31030 issue with symbolic link created with poststart #31109

Merged

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Jan 13, 2025

Proposed Changes

This pull request includes several updates to the backup directory configuration and improvements to the ImportStarterUtil class for handling file operations more robustly. The most significant changes are the introduction of a configurable backup directory path, enhancements to file handling in ImportStarterUtil, and updates to the dotmarketing-config.properties file.

Backup Directory Configuration:

  • Added a method to retrieve a configurable backup directory path with a default fallback.

File Handling Improvements:

  • Refactored the deleteTempFiles method to use Java NIO for better file handling and safety.
  • Enhanced the validateZipFile method to ensure proper setup using Java NIO features and added concurrency safety.

Fixes

#31030

This PR fixes: #31030

@dcolina dcolina marked this pull request as ready for review January 15, 2025 09:59
@dcolina dcolina added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 2653b71 Jan 15, 2025
36 checks passed
@dcolina dcolina deleted the issue-31030-issue-with-symbolic-link-created-with-poststart branch January 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with symbolic link created with postStart and starter.zip logic
4 participants