Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(UVE): Enhance UX on Personalization workflow #31125

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Jan 14, 2025

This pull request includes several changes to improve the functionality and user experience of the dot-ema-editor components, as well as updates to the tests to cover new scenarios. The most important changes include updates to the DotUveToolbarComponent and EmaContentletToolsComponent components, as well as modifications to the SCSS files and test cases.

Component Updates:

  • dot-uve-toolbar.component.ts: Added error handling for the personalization confirmation process. If the process fails, an error message is displayed, and the persona selector is reset.

  • ema-contentlet-tools.component.ts: Added a new input property disableDeleteButton to control the state of the delete button. The button is disabled and shows a tooltip when disableDeleteButton is set.

SCSS Updates:

Test Updates:

Store and Mock Updates:

  • models.ts: Added disableDeleteButton to the EditorProps interface to support the new functionality in the EmaContentletToolsComponent.

  • withEditor.spec.ts: Updated tests to include scenarios where the disableDeleteButton property is set based on the number of contents and the persona state. [1] [2]

Screenshot

Screen.Recording.2025-01-15.at.2.30.59.PM.mov

@zJaaal zJaaal marked this pull request as ready for review January 15, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 UVE: Fix Content Deletion Bug in Personalized Pages
1 participant