-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): fast playwright install #3543
Conversation
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://50df81c5.graphql-yoga.pages.dev |
Ah, this rule is preventing package use of dev deps from monorepo. I'd prefer it allowed it. Will look more into this lint rule. |
You can ignore that rule in that specific line |
Installing Playwright deps involves two parts: browser binaries and then some other OS deps. OS deps are not currently cached and eat up most time. Between two runs (1, 2, the time went up by 30s (I am assuming b/c of variable registry latency or some such). Investigating. Not sure we need the OS deps. Will try skipping that part. |
Related microsoft/playwright#7249 (to put this PR on their issue back references). |
This is great @jasonkuhrt ! I love it <3 |
This PR improves Playwright install times on CI down to ~4 seconds (on cache hit).
It addresses: #3540 (comment)
It also brings refactoring benefits:
Closes #3544