Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event metadata #925

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add event metadata #925

wants to merge 8 commits into from

Conversation

brage-andreas
Copy link
Member

@brage-andreas brage-andreas commented May 14, 2024

This PR adds:

  • Showing which businesses and committees organize/host the event
  • Showing event organizers for easier contact

Note that this PR would need to be extended with a PR adding and exposing the event organizers.

Example:
image

@junlarsen
Copy link
Member

Note that this PR would need to be extended with a PR adding and exposing the event author's name.

Do we want that, or is it needed? I'm not sure if showing that Brage made the event adds any value to the users?

@henrikhorluck
Copy link
Member

henrikhorluck commented May 15, 2024

Note that this PR would need to be extended with a PR adding and exposing the event author's name.

Do we want that, or is it needed? I'm not sure if showing that Brage made the event adds any value to the users?

Instead of author it should be the person(s) organizing the event, so they could be contacted directly.

@henrikskog
Copy link
Contributor

I'm also a bit skeptical to if this is a feature we actually want. Nice design though 👍

Instead of author it should be the person(s) organizing the event, so they could be contacted directly.

I think this would be a really useful!

<section className="flex flex-row space-x-8">
<div className="flex flex-row space-x-4">{[...committeeList, ...companyList]}</div>
<div className="flex flex-row space-x-4 text-slate-9 items-center">
<span>Lagt ut {formatDate(event.createdAt)}</span>
Copy link
Member

@henrikhorluck henrikhorluck Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In OW4 createdAt and publication time are two separate things, and I don't think we actually store the publication time? (Which would be the last time is_public was set to true.)

Aka: we support(ed) hidden events, no need to leak creation-timestamp

Though it would be nice if we could have like "recently added"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants