Update aspnet-core-module.md #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I narrowed the `web.config` files' `aspNetCore` elements. I vaguely recall either reading or being told that horizontal scrolling isn't good in the docs. Let me know if I'm off base there, and I'll widen those files back out. I also corrected the `stdout` log filename to the correct default value of `aspnetcore-stdout`. @Tratcher I tried to flesh out the bit on why the `ASPNETCORE_ENVIRONMENT` var might be set in this way. Does that language look ok? ... or what would you suggest? The reason I wanted to call it out a bit is that I'm concerned that devs will read it and draw some sort of incorrect conclusion about it being required or a best practice. @Rick-Anderson I updated the "ms.date: 11/18/2016" date to 11/18. Let me know if I need to change that back to its former value.
|
Hi @guardrex, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Tratcher
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2206
I narrowed the
web.configfiles'aspNetCoreelements. I vaguely recall either reading or being told that horizontal scrolling isn't good in the docs. Let me know if I'm off base there, and I'll widen those files back out.I also corrected the
stdoutlog filename to the correct default value ofaspnetcore-stdout.@Tratcher I tried to flesh out the bit on why the
ASPNETCORE_ENVIRONMENTvar might be set in this way. Does that language look ok? ... or what would you suggest? The reason I wanted to call it out a bit is that I'm concerned that devs will read it and draw some sort of incorrect conclusion about it being required or a best practice.@Rick-Anderson I updated the "ms.date: 11/18/2016" date to 11/18. Let me know if I need to change that back to its former value.