Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blazor] Add new Blazor Web Template #48285

Merged
merged 13 commits into from
May 23, 2023
Merged

[Blazor] Add new Blazor Web Template #48285

merged 13 commits into from
May 23, 2023

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented May 17, 2023 •
edited
Loading

This is the new template for full stack blazor. It contains 3 options:

  • --use-server to add support for server rendered components.
  • --use-wasm to add support for webassembly rendered components.
  • -pwa to add support for PWA

The template is a single project template and multitargets when you want to use webassembly. The server and webassembly options are hidden until we add support for them.

All templates can be seen instantiated with different values (except pwa) here

@javiercn javiercn requested a review from a team as a code owner May 17, 2023 15:52
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 17, 2023
@javiercn javiercn force-pushed the javiercn/blazor-web-template branch from 27af17d to 25151fb Compare May 17, 2023 16:19
mkArtakMSFT
mkArtakMSFT approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javiercn.
Let's wait for more feedback from the experts.

...ProjectTemplates/content/Components-CSharp/.template.config/localize/templatestrings.cs.json Show resolved Hide resolved
src/ProjectTemplates/Web.ProjectTemplates/content/Components-CSharp/Program.Browser.cs Outdated Show resolved Hide resolved
src/ProjectTemplates/Web.ProjectTemplates/content/Components-CSharp/Pages/Counter.razor Show resolved Hide resolved
@javiercn
Copy link
Member Author

Any last feedback before this gets merged?

@javiercn javiercn merged commit 426b8b4 into main May 23, 2023
@javiercn javiercn deleted the javiercn/blazor-web-template branch May 23, 2023 08:34
@ghost ghost added this to the 8.0-preview5 milestone May 23, 2023
@davidfowl
Copy link
Member

Is there an empty template like this as well?

@javiercn
Copy link
Member Author

@davidfowl nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards DamianEdwards left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@danroth27 danroth27 danroth27 left review comments

@dougbu dougbu dougbu left review comments

@MeikTranel MeikTranel MeikTranel left review comments

@itsmuntadhar itsmuntadhar itsmuntadhar left review comments

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging this pull request may close these issues.
10 participants
@javiercn @davidfowl @DamianEdwards @SteveSandersonMS @danroth27 @dougbu @MeikTranel @MackinnonBuck @itsmuntadhar @mkArtakMSFT