Fix flaky Kestrel Http/2 Stream tests #59820
Open
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use inline pipe scheduling which means the
StartStreamAsync
call will call continuations inline which will add the stream to the connection before returning. However, inline continuations relies on a continuation actually being present. So all these tests relied on a race condition where we had an activepipeReader.ReadAsync
call in order to call the continuation inline. If you add a delay or pause the thread right before theReadAsync
inHttp2Connection.cs
then you can force the race and cause_connection._streams[1];
to fail as there is no stream present yet.The fix is to make sure the stream is present, and we attain that by making sure the app code is running which is after the stream has been created.