Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition for BuildAfterTargetingPack #60147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 1, 2025

We don't want to build this during source-build, but we do want to build it in the VMR.

Part of #60146

Test build https://dev.azure.com/dnceng/internal/_build/results?buildId=2633084&view=results

@wtgodbe wtgodbe requested a review from mmitche February 1, 2025 00:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 1, 2025
@@ -76,19 +76,19 @@
</MSBuild>
</Target>
Copy link
Member

@akoeplinger akoeplinger Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should GetReferencesProvidedDelayedProjects be filtered out for source build as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants