Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Update more projects to SL 121 cert for signing
Browse files Browse the repository at this point in the history
  • Loading branch information
weshaggard committed Jun 22, 2018
1 parent cdd11be commit b9859a7
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 31 deletions.
22 changes: 11 additions & 11 deletions src/mscorlib/System.Private.CoreLib.csproj
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />

<!-- Include common build properties -->
<Import Project="..\..\dir.props" />

<!-- Compilation options -->
<PropertyGroup>
<AvailablePlatforms>amd64,x86,arm,arm64</AvailablePlatforms>
Expand All @@ -17,13 +17,13 @@

<OutputType>Library</OutputType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>

<!-- This prevents the default MsBuild targets from referencing System.Core.dll -->
<AddAdditionalExplicitAssemblyReferences>false</AddAdditionalExplicitAssemblyReferences>
<!-- These prevent the default MsBuild targets from referencing System.dll and mscorlib.dll -->
<NoStdLib>true</NoStdLib>
<NoCompilerStandardLib>true</NoCompilerStandardLib>

<SubsystemVersion>6.00</SubsystemVersion>
<UTF8OutPut>true</UTF8OutPut>
<HighEntropyVA>true</HighEntropyVA>
Expand Down Expand Up @@ -71,7 +71,7 @@
<PlatformTarget>AnyCPU</PlatformTarget>
<DefineConstants>WIN64;ARM64;$(DefineConstants)</DefineConstants>
</PropertyGroup>

<!-- Configuration specific properties -->
<PropertyGroup Condition="'$(Configuration)' == 'Debug' or '$(Configuration)' == 'Checked'">
<DebugSymbols>true</DebugSymbols>
Expand Down Expand Up @@ -116,20 +116,20 @@
<MscorlibDir>$(MSBuildThisFileDirectory)</MscorlibDir>
<NlpObjDir>$(BclSourcesRoot)\System\Globalization\Tables</NlpObjDir>
</PropertyGroup>

<!-- Output paths -->
<PropertyGroup>
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)' == ''">$(RootBinDir)obj</BaseIntermediateOutputPath>
<IntermediateOutputPath Condition="'$(IntermediateOutputPath)' == ''">$(BaseIntermediateOutputPath)\$(BuildOS).$(BuildArch).$(Configuration)</IntermediateOutputPath>
<OutputPath Condition="'$(OutputPath)' == ''">$(BaseIntermediateOutputPath)\$(BuildOS).$(BuildArch).$(Configuration)</OutputPath>
<FinalOutputPath Condition="'$(FinalOutputPath)' == ''">$(BinDir)</FinalOutputPath>
</PropertyGroup>

<!-- Msbuild variables needed to get CoreCLR features to be set properly. -->
<PropertyGroup>
<ClrProduct>core_clr</ClrProduct>
<BuildForCoreSystem>true</BuildForCoreSystem>

<!-- These are needed by BCLRewriter -->
<_BuildType Condition="'$(Configuration)' == 'Debug'">chk</_BuildType>
<_BuildType Condition="'$(Configuration)' == 'Checked'">chk</_BuildType>
Expand All @@ -139,7 +139,7 @@
<TargetArch Condition="'$(Platform)'=='x86'">i386</TargetArch>
<TargetArch Condition="'$(Platform)'!='x86'">$(Platform)</TargetArch>
</PropertyGroup>

<!-- CLR Features -->
<Import Project="$(MSBuildThisFileDirectory)..\..\clr.coreclr.props" />
<Import Project="$(MSBuildThisFileDirectory)..\..\clr.defines.targets" />
Expand All @@ -164,7 +164,7 @@
<Compile Include="@(MscorlibSources)">
</Compile>
</ItemGroup>

<!-- Resources -->
<ItemGroup>
<SplitTextStringResource Include="$(BclSourcesRoot)\System.Private.CoreLib.txt">
Expand All @@ -181,7 +181,7 @@
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.Targets" />

<PropertyGroup>
<StrongNameSig>Silverlight</StrongNameSig>
<StrongNameSig>SilverlightCert121</StrongNameSig>
</PropertyGroup>

<!-- Import signing tools -->
Expand Down
10 changes: 5 additions & 5 deletions src/mscorlib/facade/mscorlib.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />

<PropertyGroup>
<AssemblyName>mscorlib</AssemblyName>
<ProjectGuid>{263342A6-FC48-4CFC-B16A-2AF964D3536C}</ProjectGuid>
Expand Down Expand Up @@ -55,8 +55,8 @@
<PropertyGroup>
<BaseIntermediateOutputPath>$(RootBinDir)\obj</BaseIntermediateOutputPath>
<!-- Note the trailing '\\' - they are needed so that genfacade does not fail due to an invalid path
In particular, the facadepath is sent in quotes.
And the IntermediateOutputPath is required to end in a '\' in the coreclr repo. This means that the
In particular, the facadepath is sent in quotes.
And the IntermediateOutputPath is required to end in a '\' in the coreclr repo. This means that the
facadepath ends up being sent as 'mypath\"' and that trips the Path normalization.
Introducing a second '\' tricks the normalization logic to treat this '\\"' as '\"' and not complain. -->
<IntermediateOutputPath>$(BaseIntermediateOutputPath)\$(BuildOS).$(BuildArch).$(Configuration)\facade\\</IntermediateOutputPath>
Expand All @@ -66,7 +66,7 @@
<ItemGroup>
<ProjectReference Include="..\System.Private.CoreLib.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Include="TypeForwards.cs" />
</ItemGroup>
Expand All @@ -76,7 +76,7 @@
</ItemGroup>

<PropertyGroup>
<StrongNameSig>Silverlight</StrongNameSig>
<StrongNameSig>SilverlightCert121</StrongNameSig>
</PropertyGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
Expand Down
22 changes: 11 additions & 11 deletions src/mscorlib/mscorlib.csproj
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />

<!-- Include common build properties -->
<Import Project="..\..\dir.props" />

<!-- Compilation options -->
<PropertyGroup>
<AvailablePlatforms>amd64,x86,arm,arm64</AvailablePlatforms>
Expand All @@ -17,13 +17,13 @@

<OutputType>Library</OutputType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>

<!-- This prevents the default MsBuild targets from referencing System.Core.dll -->
<AddAdditionalExplicitAssemblyReferences>false</AddAdditionalExplicitAssemblyReferences>
<!-- These prevent the default MsBuild targets from referencing System.dll and mscorlib.dll -->
<NoStdLib>true</NoStdLib>
<NoCompilerStandardLib>true</NoCompilerStandardLib>

<SubsystemVersion>6.00</SubsystemVersion>
<UTF8OutPut>true</UTF8OutPut>
<HighEntropyVA>true</HighEntropyVA>
Expand Down Expand Up @@ -69,7 +69,7 @@
<PlatformTarget>AnyCPU</PlatformTarget>
<DefineConstants>WIN64;ARM64;$(DefineConstants)</DefineConstants>
</PropertyGroup>

<!-- Configuration specific properties -->
<PropertyGroup Condition="'$(Configuration)' == 'Debug' or '$(Configuration)' == 'Checked'">
<DebugSymbols>true</DebugSymbols>
Expand Down Expand Up @@ -114,20 +114,20 @@
<MscorlibDir>$(MSBuildThisFileDirectory)</MscorlibDir>
<NlpObjDir>$(BclSourcesRoot)\System\Globalization\Tables</NlpObjDir>
</PropertyGroup>

<!-- Output paths -->
<PropertyGroup>
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)' == ''">$(RootBinDir)obj</BaseIntermediateOutputPath>
<IntermediateOutputPath Condition="'$(IntermediateOutputPath)' == ''">$(BaseIntermediateOutputPath)\$(BuildOS).$(BuildArch).$(Configuration)</IntermediateOutputPath>
<OutputPath Condition="'$(OutputPath)' == ''">$(BaseIntermediateOutputPath)\$(BuildOS).$(BuildArch).$(Configuration)</OutputPath>
<FinalOutputPath Condition="'$(FinalOutputPath)' == ''">$(BinDir)</FinalOutputPath>
</PropertyGroup>

<!-- Msbuild variables needed to get CoreCLR features to be set properly. -->
<PropertyGroup>
<ClrProduct>core_clr</ClrProduct>
<BuildForCoreSystem>true</BuildForCoreSystem>

<!-- These are needed by BCLRewriter -->
<_BuildType Condition="'$(Configuration)' == 'Debug'">chk</_BuildType>
<_BuildType Condition="'$(Configuration)' == 'Checked'">chk</_BuildType>
Expand All @@ -137,7 +137,7 @@
<TargetArch Condition="'$(Platform)'=='x86'">i386</TargetArch>
<TargetArch Condition="'$(Platform)'!='x86'">$(Platform)</TargetArch>
</PropertyGroup>

<!-- CLR Features -->
<Import Project="$(MSBuildThisFileDirectory)..\..\clr.coreclr.props" />
<Import Project="$(MSBuildThisFileDirectory)..\..\clr.defines.targets" />
Expand All @@ -162,7 +162,7 @@
<Compile Include="@(MscorlibSources)">
</Compile>
</ItemGroup>

<!-- Resources -->
<ItemGroup>
<SplitTextStringResource Include="$(BclSourcesRoot)\mscorlib.txt">
Expand All @@ -179,7 +179,7 @@
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.Targets" />

<PropertyGroup>
<StrongNameSig>Silverlight</StrongNameSig>
<StrongNameSig>SilverlightCert121</StrongNameSig>
</PropertyGroup>

<!-- Import signing tools -->
Expand Down
8 changes: 4 additions & 4 deletions src/mscorlib/ref/mscorlib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@

<OutputType>Library</OutputType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>

<!-- This prevents the default MsBuild targets from referencing System.Core.dll -->
<AddAdditionalExplicitAssemblyReferences>false</AddAdditionalExplicitAssemblyReferences>
<!-- These prevent the default MsBuild targets from referencing System.dll and mscorlib.dll -->
<NoStdLib>true</NoStdLib>
<NoCompilerStandardLib>true</NoCompilerStandardLib>

<ErrorReport>prompt</ErrorReport>
<Optimize Condition="'$(Optimize)' == ''">true</Optimize>
<CLSCompliant>true</CLSCompliant>
Expand All @@ -38,7 +38,7 @@
<PropertyGroup Condition="'$(TargetsUnix)'!='true'">
<DefineConstants>$(DefineConstants);FEATURE_COREFX_GLOBALIZATION;FEATURE_COMINTEROP</DefineConstants>
</PropertyGroup>

<!-- Roslyn does not support writing PDBs on Unix -->
<PropertyGroup Condition="'$(OsEnvironment)' == 'Unix'">
<DebugSymbols>false</DebugSymbols>
Expand Down Expand Up @@ -68,7 +68,7 @@
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.Targets" />

<PropertyGroup>
<StrongNameSig>Silverlight</StrongNameSig>
<StrongNameSig>SilverlightCert121</StrongNameSig>
</PropertyGroup>

<!-- Import signing tools -->
Expand Down

0 comments on commit b9859a7

Please sign in to comment.