Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow GITHUB_TOKEN as an action.yml input #265

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Flow GITHUB_TOKEN as an action.yml input #265

merged 1 commit into from
Sep 7, 2023

Conversation

IEvangelist
Copy link
Member

In this PR:

  • The ${{ secrets.* }} expressions don't work within action.yml files.
  • Instead, we must flow the GITHUB_TOKEN through as an input.

Fixes #264

IEvangelist added a commit to IEvangelist/docs that referenced this pull request Sep 7, 2023
@IEvangelist
Related to dotnet/docs-tools#265
849a951
@IEvangelist IEvangelist mentioned this pull request Sep 7, 2023
Merged
BillWagner
BillWagner approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Let's :shipit:

@IEvangelist IEvangelist merged commit cd52da0 into dotnet:main Sep 7, 2023
9 checks passed
IEvangelist added a commit to dotnet/docs that referenced this pull request Sep 7, 2023
@IEvangelist
Related to dotnet/docs-tools#265 (#36996)
52a9058
IEvangelist added a commit to IEvangelist/docs that referenced this pull request Oct 2, 2023
@IEvangelist
Related to dotnet/docs-tools#265 (dotnet#36996)
22d67fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to fix the action.yml of the dotnet-version-updater composite
2 participants
@IEvangelist @BillWagner