Handle per-semester parents in Quest #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
semester-change
branch
from
c92ac71
to
32f924b
Compare
IEvangelist
approved these changes
Sep 25, 2024
This reverts commit 8e028fd45dd4b3ec35289dc60f1d7f303cf08325.
Move some code around to make it easier to add the config features without extensive copying.
Set the parent based on semester + parent config.
Co-authored-by: David Pine <[email protected]>
BillWagner
force-pushed
the
semester-change
branch
from
e16e1d0
to
8007322
Compare
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 updated Sequester to handle parents per semester. This updates the config to respond to those changes.
BillWagner
added a commit
to BillWagner/AspNetCore.Docs
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 enhances the config object to support different parents per semester. This adds the updated config for that purpose.
BillWagner
added a commit
to BillWagner/docs-aspire
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 enhances the config object to have different parents per semester. This PR updates the config to use the correct parents in both active semesters.
BillWagner
added a commit
to BillWagner/docs-maui
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 enhances the Sequester config so that parents can change per semester. This PR updates the config in this repo to match
BillWagner
added a commit
to BillWagner/maui-samples
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 enhances Sequester to allow for different parents per semester. This PR updates the config to match.
BillWagner
added a commit
to BillWagner/dotnet-api-docs
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 updates Sequester to provide for different parents each semester. This PR updates the config to match.
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 updated Sequester to handle parents per semester. This updates the config to respond to those changes.
BillWagner
added a commit
to dotnet/dotnet-api-docs
that referenced
this pull request
Sep 26, 2024
dotnet/docs-tools#413 updates Sequester to provide for different parents each semester. This PR updates the config to match.
davidbritch
pushed a commit
to dotnet/maui-samples
that referenced
this pull request
Sep 27, 2024
dotnet/docs-tools#413 enhances Sequester to allow for different parents per semester. This PR updates the config to match.
davidbritch
pushed a commit
to dotnet/docs-maui
that referenced
this pull request
Sep 27, 2024
dotnet/docs-tools#413 enhances the Sequester config so that parents can change per semester. This PR updates the config in this repo to match
BillWagner
added a commit
to dotnet/AspNetCore.Docs
that referenced
this pull request
Sep 27, 2024
dotnet/docs-tools#413 enhances the config object to support different parents per semester. This adds the updated config for that purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three sets of changes here:
semesterandLabeltags are both optional:Labelis null, the parentNode becomes the default node for that semester.semesteris null, this parentNode is used for all semesters. This is primarily for backwards compatibility