Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update net8 target to net8.0 #421

Merged
merged 1 commit into from
Oct 4, 2024
Merged

update net8 target to net8.0 #421

merged 1 commit into from
Oct 4, 2024

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Oct 4, 2024

net8 is not a standard target framework name which should not be used, update to the standard net8.0

image

https://github.com/dotnet/designs/blob/main/accepted/2020/net5/net5.md#what-about-net-10

BillWagner
BillWagner approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Thanks again @WeihanLi

I'll :shipit: now.

@BillWagner BillWagner merged commit b7065b2 into dotnet:main Oct 4, 2024
9 checks passed
@WeihanLi WeihanLi deleted the update-target branch October 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeihanLi @BillWagner