Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #36746

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Merge main into live #36746

merged 8 commits into from
Aug 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2023

Please don't squash-merge this PR.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/csharp/fundamentals/tutorials/classes.md Explore object oriented programming with classes and objects
docs/csharp/programming-guide/classes-and-structs/object-and-collection-initializers.md Object and Collection Initializers (C# Programming Guide)
docs/csharp/whats-new/csharp-12.md What's new in C# 12 - C# Guide
docs/fundamentals/code-analysis/quality-rules/ca1003.md CA1003: Use generic event handler instances
docs/fundamentals/code-analysis/quality-rules/ca1010.md docs/fundamentals/code-analysis/quality-rules/ca1010
docs/fundamentals/code-analysis/quality-rules/ca1012.md CA1012: Abstract types should not have public constructors
docs/fundamentals/code-analysis/quality-rules/ca1014.md "CA1014: Mark assemblies with CLSCompliantAttribute (code analysis)"
docs/fundamentals/code-analysis/quality-rules/ca1016.md CA1016: Mark assemblies with AssemblyVersionAttribute
docs/fundamentals/code-analysis/quality-rules/ca1017.md docs/fundamentals/code-analysis/quality-rules/ca1017
docs/fundamentals/code-analysis/quality-rules/ca1018.md CA1018: Mark attributes with AttributeUsageAttribute
docs/fundamentals/code-analysis/quality-rules/ca1019.md "CA1019: Define accessors for attribute arguments (code analysis)"
docs/fundamentals/code-analysis/quality-rules/ca1021.md CA1021: Avoid out parameters
docs/fundamentals/code-analysis/quality-rules/ca1024.md CA1024: Use properties where appropriate
docs/fundamentals/code-analysis/quality-rules/ca1027.md docs/fundamentals/code-analysis/quality-rules/ca1027
docs/fundamentals/code-analysis/quality-rules/ca1028.md CA1028: Enum storage should be Int32
docs/fundamentals/code-analysis/quality-rules/ca1031.md "CA1031: Do not catch general exception types (code analysis)"
docs/fundamentals/code-analysis/quality-rules/ca1032.md CA1032: Implement standard exception constructors
docs/fundamentals/code-analysis/quality-rules/ca1033.md docs/fundamentals/code-analysis/quality-rules/ca1033
docs/fundamentals/code-analysis/quality-rules/ca1034.md CA1034: Nested types should not be visible
docs/fundamentals/code-analysis/quality-rules/ca1036.md "CA1036: Override methods on comparable types (code analysis)"
docs/fundamentals/code-analysis/quality-rules/ca1040.md CA1040: Avoid empty interfaces
docs/fundamentals/code-analysis/quality-rules/ca1041.md CA1041: Provide ObsoleteAttribute message
docs/fundamentals/code-analysis/quality-rules/ca2218.md docs/fundamentals/code-analysis/quality-rules/ca2218
docs/fundamentals/code-analysis/quality-rules/ca2224.md CA2224: Override Equals on overloading operator equals

FrediKats and others added 8 commits August 17, 2023 15:01
* publish speclet

Publish the collection expressions speclet, add paragraph in the What's new article.

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <[email protected]>

* remove confusing sample

Respond to feedback.

---------

Co-authored-by: Tom Dykstra <[email protected]>
#36728)

* Correct typo for s_accountNumberSeed field

* Assign to Number directly without using `this.`

To keep the embedded code presented to user in snippets matching the
code in the full example in BankAccounts.cs, `this.` accessing was
removed in favor of direct invoking the `Number` field.
This is because in `BankAccounts.cs` the `Number` field is also accessed
without `this` in the constructor.
Fix comment on the 'init' accessor
* Update docfx.json

* Whoops, swapped them around!
@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 18, 2023
@BillWagner BillWagner merged commit e1bb084 into live Aug 18, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants