Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code example output on roundtrip decimal #43162

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix code example output on roundtrip decimal #43162

merged 1 commit into from
Oct 23, 2024

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Oct 22, 2024 •
edited by github-actions bot
Loading

Summary

  • Wrote some code to test locally.
  • Adjusted the captured output text to differentiate .NET and .NET Framework.

Fixes #41766

Internal previews

📄 File 🔗 Preview link
docs/standard/base-types/standard-numeric-format-strings.md docs/standard/base-types/standard-numeric-format-strings

@dotnetrepoman dotnetrepoman bot added this to the October 2024 milestone Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Oct 22, 2024
@adegeo adegeo marked this pull request as ready for review October 22, 2024 19:14
@adegeo adegeo removed request for a team and IEvangelist October 22, 2024 19:14
@adegeo
Copy link
Contributor Author

adegeo commented Oct 22, 2024

@BillWagner This has errors from snippets5000 because of the legacy code. I only adjusted the output text of the snippet. With 42 snippets, porting is out of scope.

@adegeo adegeo enabled auto-merge (squash) October 22, 2024 19:16
@adegeo adegeo disabled auto-merge October 22, 2024 19:16
BillWagner
BillWagner approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @adegeo

Let's :shipit:

@adegeo adegeo merged commit eff72a7 into main Oct 23, 2024
10 of 11 checks passed
@adegeo adegeo deleted the adegeo-round-41766 branch October 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
October 2024
Development

Successfully merging this pull request may close these issues.

Round Trip Format Example - Outdated code sample or no longer needed?
2 participants
@adegeo @BillWagner