Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for SYSLIB5003 #43288

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add docs for SYSLIB5003 #43288

wants to merge 8 commits into from

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Nov 1, 2024

Comment on lines +571 to +574
},
{
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib5003.md",
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib5003"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren Do we need this? I don't understand the logic for which pages need this and which don't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is only needed if you renamed or deleted a file after it was published.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this file can be reverted then.

docs/fundamentals/syslib-diagnostics/syslib5003.md Outdated Show resolved Hide resolved
docs/fundamentals/syslib-diagnostics/syslib5003.md Outdated Show resolved Hide resolved
docs/navigate/tools-diagnostics/toc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also add a link from the experimental-overview.md file?

Comment on lines +571 to +574
},
{
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib5003.md",
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib5003"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is only needed if you renamed or deleted a file after it was published.

docs/fundamentals/syslib-diagnostics/syslib5003.md Outdated Show resolved Hide resolved
@kunalspathak
Copy link
Member Author

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 changes left for reverting files that didn't need updates, but then approved.

Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cleanliness, I suggest reverting this file (just a final line ending difference remains).

@jeffhandley
Copy link
Member

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

I overlooked this. The experimental-overview page should link to this one per @gewarren's suggestion. The table's first cell that has the diagnostic ID can just become a link to this page; that should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants