-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for SYSLIB5003 #43288
base: main
Are you sure you want to change the base?
Add docs for SYSLIB5003 #43288
Conversation
}, | ||
{ | ||
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib5003.md", | ||
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib5003" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren Do we need this? I don't understand the logic for which pages need this and which don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is only needed if you renamed or deleted a file after it was published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; this file can be reverted then.
docs/fundamentals/syslib-diagnostics/source-generator-overview.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also add a link from the experimental-overview.md file?
}, | ||
{ | ||
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib5003.md", | ||
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib5003" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is only needed if you renamed or deleted a file after it was published.
Co-authored-by: Genevieve Warren <[email protected]>
https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 changes left for reverting files that didn't need updates, but then approved.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cleanliness, I suggest reverting this file (just a final line ending difference remains).
I overlooked this. The experimental-overview page should link to this one per @gewarren's suggestion. The table's first cell that has the diagnostic ID can just become a link to this page; that should be sufficient. |
Summary
Describe your changes here.
Contributes to #42812
Internal previews